Not so dumb cursor copy #7040
Open
Not so dumb cursor copy #7040
+172
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want to have as little lag as possible on nvidia, we should make aquamarine support drm_dumb (cpu) buffers for planes (probably only cursor, doing that for primary is sacrilege) and then use the cpu to render the pointer. 32x32 or even 64x64 cursors with We don't do anything to the cursors that would benefit massively from a gpu (transforms, etc) Some plugins do, but it's better to fix the experience for 99% of users and worry about plugins for 1% later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
cursor:allow_dumb_copy = true.cursor:allow_slow_copyWith
cursor:allow_slow_copy = truecreates an additional renderable swapchain if rendering to cursor swapchain fails. Renders to this swapchain buffer and copies the result to main cursor swapchain.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I don't really know what I am doing here %) Some bits might be totally wrong. But this works for me and doesn't seem to cause any issues.
This code skips many sanity checks because it assumes that fallback buffer will get the same size and format as the main one.
Is it ready for merging, or does it need work?
Requires hyprwm/aquamarine#31